gh-124503: simplified ast.literal_eval #137010
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Is there anything that needs to be done to merge this PR? |
|
I think that it it is worth to add a small NEWS entry. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
The implementation does not create anymore local functions which reduces the overhead for small inputs. Some other calls are inlined into a single `_convert_literal` function. We have a gain of 10-20% for small inputs and only 1-2% for bigger inputs.
Done |
| @@ -0,0 +1 @@ | |||
| :func:`ast.literal_eval` simplified to avoid local functions. | |||
There was a problem hiding this comment.
This is an implementation detail. Write something that is interesting to the user -- how much the function has become faster for small input.
Also, please do not use force push -- it forces us to review already reviewed code again.
The implementation does not create anymore local functions which reduces the overhead for small inputs. Some other calls are inlined into a single
_convert_literalfunction.We have a gain of 10-20% for small inputs and only 1-2% for bigger inputs.
ast.literal_evalImplementation #124503