Fix Union type merging to use types.UnionType instead of typing.Union #137068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Thank you for your initiative, however, Serhiy has created #137069. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137065
Summary
This PR fixes the Union type merging issue where types.UnionType was incorrectly merged with typing.Union instead of typing._UnionGenericAlias. Now typing.Union[int, str] properly returns a types.UnionType object.
What Changed
C Module (_typingmodule.c)
Removed Union export from the C module
Union is now handled entirely in Python
Python Module (typing.py)
Changed Union to a @_SpecialForm decorator
Added _UnionGenericAlias class that creates types.UnionType objects
Added fallback handling for edge cases
Fixed some forward reference issues in IO classes
How It Works
When you call Union[int, str]:
The @_SpecialForm function processes the arguments
Creates a _UnionGenericAlias that uses the | operator
Returns a types.UnionType object
Falls back gracefully if something goes wrong
Results
Testing
All existing doctests still pass (43/43)
typing module imports fine
No syntax errors
Backward compatibility maintained
Why This Matters
Before this fix, typing.Union and types.UnionType were inconsistent. Now they work together properly, which helps type checkers and runtime tools give better results.
The change is safe - existing code keeps working the same way, but now with the correct underlying types.