Exclude _testclinic_depr.c.h from c-analyzer #137086
Merged
+225
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_testclinic.c mocks out PY_VERSION_HEX to 3.8 before including _testclinic_depr.c.h to avoid the errors the preprocessor would otherwise throw due to the deprecation feature it is testing.
This restores Modules/_testclinic.c to match the same file in the 3.14 branch.
Partially revert 74e2acd This restores Modules/_testclinic.c to match the same file in the 3.14 branch.
emmatyping
approved these changes
Jul 24, 2025
|
Ah, looks like you also need to update all the error messages in test_clinic :) |
Partially revert 74e2acd This restores Modules/_testclinic.c to match the same file in the 3.14 branch.
Partially revert 74e2acd This restores Modules/_testclinic.c to match the same file in the 3.14 branch.
|
🤦♂️ done. |
|
I clicked re-run failed jobs because the failures in https://github.com/python/cpython/actions/runs/16506792861/job/46679447457?pr=137086 look like a flake? (Maybe this should be reported as an issue) |
|
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 24, 2025
_testclinic.c mocks out PY_VERSION_HEX to 3.8 before including _testclinic_depr.c.h to avoid the errors the preprocessor would otherwise throw due to the deprecation feature it is testing. Also partially revert 74e2acd: this restores Modules/_testclinic.c to match the same file in the 3.14 branch. (cherry picked from commit d5e75c0) Co-authored-by: Zachary Ware <zach@python.org>
|
GH-137089 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jul 24, 2025
) Exclude _testclinic_depr.c.h from c-analyzer (GH-137086) _testclinic.c mocks out PY_VERSION_HEX to 3.8 before including _testclinic_depr.c.h to avoid the errors the preprocessor would otherwise throw due to the deprecation feature it is testing. (cherry picked from commit d5e75c0) Co-authored-by: Zachary Ware <zach@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also revert
_testclinic.cto match 3.14 as a test to make sure this will fix CI for the 3.14 branch.