Skip to content

gh-137093: Fix race condition in test_embed.test_bpo20891 #137094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

gh-137093: Fix race condition in test_embed.test_bpo20891 #137094

merged 1 commit into from
Jul 25, 2025
+6 −18

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Jul 25, 2025 •
edited by bedevere-app bot
Loading

Use a PyEvent instead of a lock to fix a race on the free-threaded build.

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jul 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 25, 2025
Closed
@ZeroIntensity
Copy link
Member Author

!buildbot nogil

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 166cfd7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137094%2Fmerge

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 CentOS9 NoGIL PR
  • AMD64 Fedora Rawhide NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • AMD64 Windows PGO NoGIL PR
  • aarch64 Fedora Rawhide NoGIL PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • s390x Fedora Rawhide NoGIL PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR

@ZeroIntensity ZeroIntensity merged commit 9b451fb into python:main Jul 25, 2025
66 checks passed
@ZeroIntensity ZeroIntensity deleted the fix-testembed branch July 25, 2025 12:33
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 25, 2025
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @ZeroIntensity, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b451fb457a5de9ed535a0e2f41161dfaa9a419a 3.14

@miss-islington-app
Copy link

Sorry, @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b451fb457a5de9ed535a0e2f41161dfaa9a419a 3.13

@ZeroIntensity ZeroIntensity removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 25, 2025
@ZeroIntensity
Copy link
Member Author

I'm not going to bother with manually backporting. The whole reason we backport tests is to prevent conflicts, but since there are already conflicts, it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@ZeroIntensity ZeroIntensity

Labels
skip news tests Tests in the Lib/test dir topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeroIntensity @bedevere-bot @kumaraditya303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy