GH-132532: Add new DSL macros to better declare semantics of exits at ends of instructions/uops. #137098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics of exits at ends of instructions/uops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes adds the ability to de-opt at the end an instruction.
Exits from tier 2 jump to the next instruction in tier 1.
In the case of deopting due to the eval breaker being set,
_Py_HandlePendingis called before resuming tier 1.I am taking this approach instead of checking the eval breaker before each call, as this does not cause any observable behavior change. For comparison see https://github.com/python/cpython/compare/main...faster-cpython:cpython:check-periodic-before-call?expand=1, noting the necessary changes to tests and threading module.
Although this approach adds a bit more complexity to the optimizer, it doesn't need any changes to the library or tests.