Skip to content

gh-137146: Restrict IPvFuture address parsing to RFC 3986-valid characters #137147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-137146: Restrict IPvFuture address parsing to RFC 3986-valid characters #137147

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb02be2
[PATCH] urllib.parse: Restrict IPvFuture regex to RFC 3986-valid char…
mauricelambert Jul 27, 2025
9790b02
Add blurb entries for IPvFuture validation fixes
mauricelambert Jul 27, 2025
9864ce1
gh-137146: Fix unicode characters in PIvFuture
mauricelambert Jul 28, 2025
0f0cc9b
gh-137146: Add tests on IPvFuture
mauricelambert Jul 28, 2025
5021430
Fix: reStructuredText language syntax
mauricelambert Jul 28, 2025
d528f19
gh-137146: Fix tests on IPvFuture
mauricelambert Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-137146: Fix unicode characters in PIvFuture
  • Loading branch information
@mauricelambert
mauricelambert authored Jul 28, 2025
commit 9864ce14c59a17e26e8a76de7ad05e4ce643ed82
2 changes: 1 addition & 1 deletion Lib/urllib/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def _check_bracketed_netloc(netloc):
# https://www.rfc-editor.org/rfc/rfc3986#page-49 and https://url.spec.whatwg.org/
def _check_bracketed_host(hostname):
if hostname.startswith('v'):
if not re.match(r"\Av[a-fA-F0-9]+\.[\w\.~!$&*+,;=:'()-]+\z", hostname):
if not re.match(r"\Av[a-fA-F0-9]+\.[\w\.~!$&*+,;=:'()-]+\z", hostname, flags=re.ASCII):
raise ValueError(f"IPvFuture address is invalid")
else:
ip = ipaddress.ip_address(hostname) # Throws Value Error if not IPv6 or IPv4
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy