Skip to content

gh-81325: tarfile should accept a path-like object when writing a compressed gzip #137188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2025
Merged

gh-81325: tarfile should accept a path-like object when writing a compressed gzip #137188

merged 6 commits into from
Aug 4, 2025

Conversation

aeurielesn
Copy link
Contributor

@aeurielesn aeurielesn commented Jul 28, 2025 •
edited by bedevere-app bot
Loading

@aeurielesn aeurielesn requested a review from ethanfurman as a code owner July 28, 2025 21:20
@bedevere-app bedevere-app bot mentioned this pull request Jul 28, 2025
Open
@brianschubert brianschubert added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 28, 2025
emmatyping
emmatyping approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the news entry, but otherwise looks good!

aeurielesn and others added 2 commits August 1, 2025 21:41
@aeurielesn @emmatyping
Update Misc/NEWS.d/next/Library/2025-07-28-23-11-29.gh-issue-81325.jM…
d17ff1d 
…JFBe.rst

Co-authored-by: Emma Smith <emma@emmatyping.dev>
@aeurielesn
NEWS
06104ec
@emmatyping emmatyping merged commit 3ec3d05 into python:main Aug 4, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @aeurielesn for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
@aeurielesn @emmatyping @miss-islington
pythongh-81325: Support path-like objects with streaming TarFile (pyt…
c159498 
…honGH-137188)

(cherry picked from commit 3ec3d05)

Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com>
Co-authored-by: Emma Smith <emma@emmatyping.dev>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
@aeurielesn @emmatyping @miss-islington
pythongh-81325: Support path-like objects with streaming TarFile (pyt…
28300ed 
…honGH-137188)

(cherry picked from commit 3ec3d05)

Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com>
Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

GH-137365 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

GH-137366 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 4, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 3ec3d05.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/6391) and take a look at the build logs.
  4. Check if the failure is related to this commit (3ec3d05) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/6391

Failed tests:

  • test_launcher

Failed subtests:

  • test_virtualenv_with_env - test.test_launcher.TestLauncher.test_virtualenv_with_env
  • tearDownClass - test.test_launcher.TestLauncher
  • test_search_path - test.test_launcher.TestLauncher.test_search_path
  • test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2
  • test_py_default - test.test_launcher.TestLauncher.test_py_default
  • test_recursive_search_path - test.test_launcher.TestLauncher.test_recursive_search_path
  • test_search_path_exe - test.test_launcher.TestLauncher.test_search_path_exe
  • test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3
  • test_py2_shebang_nl - test.test_launcher.TestLauncher.test_py2_shebang_nl
  • test_python_shebang - test.test_launcher.TestLauncher.test_python_shebang
  • test_shebang_command_in_venv - test.test_launcher.TestLauncher.test_shebang_command_in_venv

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 676, in test_search_path_exe
    data = self.run_py(
        [script, "-postarg"],
        env={"PATH": f"{exe.parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 606, in test_py2_shebang_nl
    data = self.run_py([script, "-postarg"])
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 552, in test_virtualenv_with_env
    data2 = self.run_py(["-V:PythonTestSuite/3"], env={**env, "PY_PYTHON": "PythonTestSuite/3"})
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 571, in test_python_shebang
    data = self.run_py([script, "-postarg"])
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 309, in tearDownClass
    delete_registry_data(key, TEST_DATA)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 129, in delete_registry_data
    with winreg.OpenKey(root, key, access=ACCESS) as hkey:
         ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 471, in test_py_default
    self.assertEqual("PythonTestSuite", data["SearchInfo.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonTestSuite' != '(null)'
- PythonTestSuite
+ (null)


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 787, in test_shebang_command_in_venv
    data = self.run_py([script], env=env)
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 662, in test_search_path
    data = self.run_py(
        [script, "-postarg"],
        env={"PATH": f"{exe.parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 687, in test_recursive_search_path
    data = self.run_py(
        [script],
        env={"PATH": f"{self.get_py_exe().parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite

AA-Turner pushed a commit that referenced this pull request Aug 5, 2025
@miss-islington @aeurielesn @emmatyping
[3.13] gh-81325: Support path-like objects with streaming TarFile (GH…
3a61ddf 
…-137188) (#137366)

Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com>
Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeurielesn @bedevere-bot @ethanfurman @emmatyping @brianschubert
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy