Skip to content

[3.14] gh-137179: Fix flaky test_history_survive_crash test (gh-137180) #137216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.14
Choose a base branch
from
Open

[3.14] gh-137179: Fix flaky test_history_survive_crash test (gh-137180) #137216

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 29, 2025 •
edited by bedevere-app bot
Loading

Kill the REPL subprocess once it prints the output from the command
immediately before the time.sleep().
(cherry picked from commit 98d462c)

Co-authored-by: Sam Gross colesbury@gmail.com

@colesbury @miss-islington
pythongh-137179: Fix flaky test_history_survive_crash test (pythongh-…
d041453 
…137180)

Kill the REPL subprocess once it prints the output from the command
immediately before the `time.sleep()`.
(cherry picked from commit 98d462c)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 29, 2025
Open
@bedevere-app bedevere-app bot mentioned this pull request Jul 29, 2025
Merged
@colesbury colesbury self-assigned this Jul 29, 2025
@colesbury
Copy link
Contributor

This just affects a test - it can wait until 3.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@colesbury colesbury

Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miss-islington @colesbury
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy