Skip to content

gh-137257: Upgrade bundled pip to 25.2 #137258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Conversation

ichard26
Copy link
Contributor

@ichard26 ichard26 commented Jul 30, 2025

I'm not sure actually how pip updates are treated for backports, but ignoring that, I'd like to ask that we hold off on merging this for a week just in case we need to cut an emergency hotfix release.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, marking as DO-NOT-MERGE per your comment:

I'd like to ask that we hold off on merging this for a week just in case we need to cut an emergency hotfix release.

I think we do backport these; the previous bump (GH-132997) was backported to 3.13.

@AA-Turner
Copy link
Member

Note that 3.14 is in RC-mode, @hugovk may reasonably want to defer backporting this to 3.14.1 -- but by then, I expect a new version of pip will have been released.

A

@hugovk
Copy link
Member

hugovk commented Jul 31, 2025

Let's backport when ready: this will get wide exposure in 3.13.6 (2025-08-05) before 3.14.0 RC2 (2025-08-26).

Thanks!

@pfmoore
Copy link
Member

pfmoore commented Jul 31, 2025

I'm not sure how this could be out of date with main? Maybe the news files? Does anyone know a good reason why I shouldn't just hit "Update branch"?

@ichard26 ping me when you are ready for this to be merged, and I'll set the merge going and do the backports. For information, we bacport new versions of pip to all currently maintained Python versions. And as in this case, if we're in the beta or RC period, we should get RM approval. As @hugovk has approved, we're good on that point.

@AA-Turner
Copy link
Member

I'm not sure how this could be out of date with main? Maybe the news files? Does anyone know a good reason why I shouldn't just hit "Update branch"?

It's a somewhat-unhelpful message, this branch is indeed behind, but not for anything that matters (hence no 'resolve conflicts' message). Clicking the button doesn't hurt, but triggers a full CI rerun, so generally best avoided. It can be helpful when the problem is with CI itself, though.

A

@ichard26
Copy link
Contributor Author

ichard26 commented Aug 4, 2025

Let's backport when ready: this will get wide exposure in 3.13.6 (2025-08-05) before 3.14.0 RC2 (2025-08-26).

It's been all quiet on the western post-release front so far (and I doubt we're going to discover any show-stopping bugs at this point) so let's get this merged now so it can be battle tested via Python 3.13.6. cc @pfmoore

@ZeroIntensity ZeroIntensity merged commit 506542b into python:main Aug 4, 2025
53 of 56 checks passed
@miss-islington-app
Copy link

Thanks @ichard26 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
(cherry picked from commit 506542b)

Co-authored-by: Richard Si <sichard26@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
(cherry picked from commit 506542b)

Co-authored-by: Richard Si <sichard26@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

GH-137361 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

GH-137362 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 4, 2025
ZeroIntensity pushed a commit that referenced this pull request Aug 4, 2025
gh-137257: Upgrade bundled pip to 25.2 (GH-137258)
(cherry picked from commit 506542b)

Co-authored-by: Richard Si <sichard26@gmail.com>
hugovk pushed a commit that referenced this pull request Aug 4, 2025
gh-137257: Upgrade bundled pip to 25.2 (GH-137258)
(cherry picked from commit 506542b)

Co-authored-by: Richard Si <sichard26@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.14 (tier-1) has failed when building commit 127ec30.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1717/builds/448) and take a look at the build logs.
  4. Check if the failure is related to this commit (127ec30) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1717/builds/448

Failed tests:

  • test_launcher

Failed subtests:

  • test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3
  • test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy