Allow anonymous unions in public headers, using _Py_ANONYMOUS
#137283
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I think that would mean more typing for little benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use an anonymous union for PyObject. This makes the workarounds available in all public headers:
__pragma(warning(disable: 4201))(with push/pop). Warning 4201 is specifically for anonymous unions, so let's disable for all of<Python.h>_Py_ANONYMOUSas__extension___Py_ANONYMOUSas nothing(Note that this is only for public headers -- CPython internals use C11, which has anonymous structs/unions.)
C API WG vote: capi-workgroup/decisions#74