Skip to content

gh-64612: Update error handlers list under open() #137304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Aug 1, 2025

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced the two-column table, with name in the first column and prose in the second, is better than a buletted list. (Especially as two tables with unaligned columns.)

The "reproduced below for convenience" sounds like the tables should be the same. Perhaps "summarized below for convenience" would be better, with additional details left out?

when writing data. This is useful for processing files in an
unknown encoding.
* - ``'surrogatepass'``
- Only available for Unicode codecs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these all Unicode codecs?

Suggested change
- Only available for Unicode codecs.
- Only available for UTF-8, UTF-16 and UTF-32 codecs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecs documentation lists the little/big endian variants, though I think wr can be less specific here.

@StanFromIreland
Copy link
Member Author

I'm not convinced the two-column table, with name in the first column and prose in the second, is better than a buletted list

I see, it is a table in the codecs docs and so, in an attempt to make them consistent converted it to (albeit a more convenient form of) a table.

@StanFromIreland StanFromIreland requested a review from encukou August 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy