gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

uxioandrade · 2025-08-01T16:17:46Z

When calling search_elf_file_for_section from search_linux_map_for_section passing a file that either doesn't exist or can't be opened correctly for a variety of reasons, this will throw an exception regardless of whether that file contains PyRuntime. The call to search_linux_map_for_section can behave as expected if it does eventually open the file with PyRuntime. After discussion, this fix removes exceptions from search_linux_map_for_section

Tested manually with the following script:

import sys
import os
import time

os.chmod("/cpython/python.exe", 0x0000)
sys.remote_exec(77223, "./remote_code.py")

Before:

/cpython# ./python.exe trigger_script.py
OSError: Cannot open ELF file '/cpython/Modules/readline.cpython-315-aarch64-linux-gnu.so (deleted)' for section 'PyRuntime' search: No such file or directory

During handling of the above exception, another exception occurred:

RuntimeError: Failed to find the PyRuntime section in process 77223 on Linux platform

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/cpython/trigger_script.py", line 11, in <module>
    sys.remote_exec(77223, "./remote_code.py")
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: PyRuntime address lookup failed during debug offsets initialization

Now

/cpython# ./python.exe trigger_script.py
RuntimeError: Failed to find the PyRuntime section in process 77223 on Linux platform

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/cpython/trigger_script.py", line 11, in <module>
    sys.remote_exec(77223, "./remote_code.py")
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: PyRuntime address lookup failed during debug offsets initialization

Issue: SystemError: <built-in function remote_exec> returned a result with an exception set #137293

python-cla-bot · 2025-08-01T16:17:50Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-08-01T16:17:51Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity

Please add a news entry, and if possible, a test case. We can probably test this by running remote_exec on a file with some weird permissions?

ZeroIntensity · 2025-08-01T17:24:33Z

Python/remote_debug.h

@@ -732,6 +732,9 @@ search_linux_map_for_section(proc_handle_t *handle, const char* secname, const c
            if (retval) {
                break;
            }
+            if (PyErr_Occurred()){


From my understanding, this should always be true at this point. If search_elf_file_for_section returns 0, there's an exception set.

It might be overly defensive but could there be no exceptions in case section is null here?

I'd have argued that was its own issue, but per discussion it seems we should just remove exceptions from search_elf_file_for_section entirely. It's not called anywhere else.

Python/remote_debug.h

pablogsal · 2025-08-01T17:53:15Z

I don't think we should print the exception. For example there are some normal conditions where we will find the target but we will have some exceptions while reading unrelated files and other cases and we don't want to confuse the users showing that error.

What do you think @godlygeek ?

godlygeek · 2025-08-01T18:43:21Z

I'm inclined to agree. Any problems encountered at this point aren't necessarily fatal, and there's no reason to ever report anything to the user if we go on to succeed.

uxioandrade · 2025-08-01T21:06:43Z

Please add a news entry, and if possible, a test case. We can probably test this by running remote_exec on a file with some weird permissions?

I might be off here but the problem with creating a test case for this is that when running remote_exec with a dummy file, the first ELF file at the top of the /proc//maps file will always be the one containing PyRuntime so the other file with weird permissions is never reached

pablogsal · 2025-08-01T21:10:51Z

Please add a news entry, and if possible, a test case. We can probably test this by running remote_exec on a file with some weird permissions?

I might be off here but the problem with creating a test case for this is that when running remote_exec with a dummy file, the first ELF file at the top of the /proc//maps file will always be the one containing PyRuntime so the other file with weird permissions is never reached

You can try with a build with --enable-shares but don't worry about a test case, it's going to be too complex. You can manually test it though by forcing a failure by hand and confirming it works

ZeroIntensity · 2025-08-01T21:13:02Z

Ok, sure, no test is fine.

I don't think search_elf_file_for_section should be setting exceptions at all, right? If we're only going to clear it, it'd be better to omit them entirely.

uxioandrade · 2025-08-01T21:31:09Z

Ok, sure, no test is fine.

I don't think search_elf_file_for_section should be setting exceptions at all, right? If we're only going to clear it, it'd be better to omit them entirely.

Yeah that makes a lot of sense, I just removed the exceptions from search_elf_file_for_section

Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issue-137293.4x3JbV.rst

…e-137293.4x3JbV.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

uxioandrade · 2025-08-01T22:12:36Z

Please add a news entry, and if possible, a test case. We can probably test this by running remote_exec on a file with some weird permissions?

I might be off here but the problem with creating a test case for this is that when running remote_exec with a dummy file, the first ELF file at the top of the /proc//maps file will always be the one containing PyRuntime so the other file with weird permissions is never reached

You can try with a build with --enable-shares but don't worry about a test case, it's going to be too complex. You can manually test it though by forcing a failure by hand and confirming it works

Sweet, that sounds good, I just added my manual test details in the description

serhiy-storchaka · 2025-08-02T07:36:36Z

I do not think that silencing all exceptions indiscriminately is a good idea. This may remove useful information.

What if just add PyErr_Clear() before calling search_elf_file_for_section() (or at the beginning of it)?

uxioandrade added 2 commits August 1, 2025 18:05

pythongh-137293: Print Exceptions in searching ELF File in Remote Debug

18786cf

pythongh-137293 print exception instead of clearing

fc3649c

uxioandrade requested a review from pablogsal as a code owner August 1, 2025 16:17

bedevere-app bot added the awaiting review label Aug 1, 2025

bedevere-app bot mentioned this pull request Aug 1, 2025

SystemError: <built-in function remote_exec> returned a result with an exception set #137293

Open

ZeroIntensity reviewed Aug 1, 2025

View reviewed changes

uxioandrade changed the title ~~gh-137293: Print Exceptions in searching ELF File in Remote Debug~~ gh-137293: Ignore Exceptions in searching ELF File in Remote Debug Aug 1, 2025

📜🤖 Added by blurb_it.

8086288

uxioandrade changed the title ~~gh-137293: Ignore Exceptions in searching ELF File in Remote Debug~~ gh-137293: Ignore Exceptions when searching ELF File in Remote Debug Aug 1, 2025

pythongh-137293 clear exception

17b9d10

pythongh-137293 remove exceptions in search_elf_file_for_section

86e73eb

ZeroIntensity reviewed Aug 1, 2025

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issue-137293.4x3JbV.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issu…

c6b5c64

…e-137293.4x3JbV.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Uh oh!

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

Are you sure you want to change the base?

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

Conversation

uxioandrade commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Aug 1, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

uxioandrade Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pablogsal commented Aug 1, 2025

Uh oh!

godlygeek commented Aug 1, 2025

Uh oh!

uxioandrade commented Aug 1, 2025

Uh oh!

pablogsal commented Aug 1, 2025

Uh oh!

ZeroIntensity commented Aug 1, 2025

Uh oh!

uxioandrade commented Aug 1, 2025

Uh oh!

Uh oh!

uxioandrade commented Aug 1, 2025

Uh oh!

serhiy-storchaka commented Aug 2, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

uxioandrade commented Aug 1, 2025 •

edited

Loading

python-cla-bot bot commented Aug 1, 2025 •

edited

Loading