gh-137288: Fix bug where boolean expressions are not associated with the correct exception handler #137310
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the correct exception handler
|
This looks reasonable to me but I don't know this code enough to review it. However, the fix will require bumping the PYC magic number in 3.14.0rc2 :( Heads up, @hugovk |
|
The code changes look good to me. I think this needs a separate pyc magic number bump for the backport. |
This reverts commit af2128c.
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 5, 2025
…ociated with the correct exception handler (pythonGH-137310). (cherry picked from commit 1f2026b) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-137427 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137288.