gh-131876: extract _hashlib helpers into a separate directory
#137319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
259a802 to
ffe7db7
Compare
…python#136995) The `Modules/hashlib.h` helper file is now removed and split into multiple files: * `Modules/_hashlib/hashlib_buffer.h` -- Utilities for getting a buffer view and handling buffer inputs. * `Modules/_hashlib/hashlib_fetch.h` -- Utilities used when fetching a message digest from a digest-like identifier. Currently, this file only contains common error messages as the fetching API is not yet implemented. * `Modules/_hashlib/hashlib_mutex.h` -- Utilities for managing the lock on cryptographic hash objects.
ffe7db7 to
2fb8a6c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
What is the point of splitting a header file into three? |
|
Maintainability for me. This will grow into more code when I plan to move some of the OpenSSL fetch interface from _hashopenssl there as I want to be able to use it in HMAC as well. However I had linker issues :( so for now I wanted to lay out the structure first. What I can do is hold this change and design the fetch API. Then merge both of them at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this reverts the revert and fixes the WASM build. The WASI build was not affected but it should have been I think but I can't seem to make it fail (maybe duplicated symbols are allowed?)
_hashliband_hmac#131876