gh-132983: _zstd: use Py_UNREACHABLE in _zstd_load_impl #137320
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ZeroIntensity
approved these changes
Aug 3, 2025
There was a problem hiding this comment.
LGTM as well.
@emmatyping Would you like to use your new green button?
AA-Turner
reviewed
Aug 3, 2025
|
Hm, how are you envisioning that? The whole point of |
|
I'm not a fan of needing logic like this, and it would be nice to exhaustively test that we never hit it, but I haven't had a good idea, no. A |
|
Anyway, the compression path already uses A |
|
Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2025
…honGH-137320) (cherry picked from commit 57eab1b8f78039142d58d207d39ae734d67952cf) Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
|
GH-137360 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 functions called
_zstd_load_impl: one for compression and one for decompression.In these functions, the
typevariable is supposed to represent the dict type. Due to the way the function is called, the dict type is always one ofDICT_TYPE_DIGESTED/DICT_TYPE_UNDIGESTED/DICT_TYPE_PREFIX. However, the implementations differs in the unreachable case:Py_UNREACHABLESystemErrorexceptionThis PR harmonizes the two implementations by using
Py_UNREACHABLE.