Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

As discussed on the bug tracker, this PR now opens the source and destination early and uses file descriptors in order to avoid a race condition where the file being copied is replaced at some point during copyfile's execution. I've just added a missing test so the modifications should have good test coverage.

Thanks,
Preston

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@pkmoore, please resolve the merge conflicts. Thanks!

@pkmoore please resolve the merge conflicts. Thanks!

This PR is stale because it has been open for 30 days with no activity.

Closing this PR as the concerns have not been addressed, and the PR has been stale for years.

@pkmoore are you still interested in this? I would be willing to pick it up and care for it until someone merges it but if I want to credit you and use your code as a basis, you wuold need to sign the CLA. If you're not interested, I will reimplement it from the discussion here and in the issue.

@pkmoore ah, I found that you have signed the cla in the past by looking at bugs.python.org. I can continue your work in a new PR but let me know if you want to take it over.