gh-88333: Drop redundant IPv6 private subnets #26209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like my PR was affected by https://www.githubstatus.com/incidents/m16jzl31gnqt; one of the Windows builds is still “pending” 12 hours later. I’ll see about a rebase and force-push tomorrow. |
The two dropped networks are wholly contained inside of 2001::/23:
```python
>>> from ipaddress import IPv6Network
>>> sub_tla_id = IPv6Network('2001::/23')
>>> sub_tla_id.supernet_of(IPv6Network('2001:2::/48'))
True
>>> sub_tla_id.supernet_of(IPv6Network('2001:10::/28'))
True
```
Any IP address that tests as private against either 2001:2::/48 or 2001:10::/28 will also test as private against 2001::/23, any IP address that is not part of 2001::/23 will also never be part of the other two.
cd31ae5 to
3b7ce0d
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
|
Poking this to un-stale it. All it takes is a review! |
MaxwellDupre
approved these changes
Jul 11, 2022
arhadthedev
approved these changes
Jul 11, 2022
|
After merging, I have realized that this is resolved already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two dropped networks are wholly contained inside of 2001::/23:
Any IP address that tests as private against either 2001:2::/48 or 2001:10::/28 will also test as private against 2001::/23, any IP address that is not part of 2001::/23 will also never be part of the other two.
https://bugs.python.org/issue44167