Skip to content

gh-91356: Add ZipInfo.mode attribute #32252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-91356: Add ZipInfo.mode attribute #32252

wants to merge 5 commits into from

Conversation

dignissimus
Copy link
Contributor

@dignissimus dignissimus commented Apr 2, 2022 •
edited by bedevere-bot
Loading

Adds the ZipInfo.mode attribute to get and set the mode of a file

https://bugs.python.org/issue47200

@dignissimus dignissimus changed the title bpo-47200: Add ZipInfo.mode attribute gh-91356: Add ZipInfo.mode attribute Apr 14, 2022
MaxwellDupre
MaxwellDupre approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 269 tests in 80.391s
OK (skipped=1)
Looks ok.

@dignissimus dignissimus mannequin mentioned this pull request Apr 10, 2022
Open
iritkatriel
iritkatriel previously requested changes Nov 26, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@iritkatriel iritkatriel dismissed their stale review November 29, 2022 12:52

Merge conflicts were resolved

@abadger
Copy link
Contributor

abadger commented Jul 19, 2025

It looks like the one additional feature this needs is mentioned on the issue:

gpshead commented on
on Dec 21, 2023

While the supplied patch adding a property for mode makes sense, I think it'd need to go a little further and handle things like the 0o40000 bit for Directory and whatever other potential bits zip files are able to represent. not just the base 9-bit posix mode values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@iritkatriel iritkatriel iritkatriel left review comments

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dignissimus @bedevere-bot @abadger @iritkatriel @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @AlexWaygood
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy