Skip to content

gh-91984: Appended '\n' to test strings in test_argparse.py(#91984) #91986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

AbhigyanBose
Copy link
Contributor

@AbhigyanBose AbhigyanBose commented Apr 27, 2022

#gh-91984: Appended '\n' to test strings in test_argparse.py(#91984)

Implementing the fix proposed in the issue description in #91984

Adding '\n' to the end of:


and

Closes #91984.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 27, 2022
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was going to fix this a long time ago, but could not find a free time for this.

@AbhigyanBose
Copy link
Contributor Author

@serhiy-storchaka Could you approve the test workflows ?

@serhiy-storchaka serhiy-storchaka merged commit 88dd227 into python:main Apr 28, 2022
@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 28, 2022
@miss-islington
Copy link
Contributor

Thanks @AbhigyanBose for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @AbhigyanBose for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AbhigyanBose and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 88dd22795925a8f47d38737ca8067eeb3f0a13aa 3.9

@miss-islington
Copy link
Contributor

Sorry @AbhigyanBose and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 88dd22795925a8f47d38737ca8067eeb3f0a13aa 3.10

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 28, 2022
@AbhigyanBose AbhigyanBose deleted the fix-issue-91984 branch April 28, 2022 13:11
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_argparse.py trailing spaces within test strings removed by make patchcheck if file is modified
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy