feat: new primitive for weakref.__call__

BobTheBuidler · BobTheBuidler · commit e6e4a6bfb47b · 2025-07-14T20:23:23.000Z
diff --git a/mypyc/ir/rtypes.py b/mypyc/ir/rtypes.py
@@ -512,6 +512,11 @@ def __hash__(self) -> int:
 # Python range object.
 range_rprimitive: Final = RPrimitive("builtins.range", is_unboxed=False, is_refcounted=True)
 
+# Python weak reference object
+weakref_rprimitive: Final = RPrimitive(
+    "weakref.ReferenceType", is_unboxed=False, is_refcounted=True
+)
+
 
 def is_tagged(rtype: RType) -> bool:
     return rtype is int_rprimitive or rtype is short_int_rprimitive
diff --git a/mypyc/primitives/weakref_ops.py b/mypyc/primitives/weakref_ops.py
@@ -1,6 +1,6 @@
 from mypyc.ir.ops import ERR_MAGIC
-from mypyc.ir.rtypes import object_rprimitive, pointer_rprimitive
-from mypyc.primitives.registry import function_op
+from mypyc.ir.rtypes import object_rprimitive, pointer_rprimitive, weakref_rprimitive
+from mypyc.primitives.registry import ERR_NEG_INT, function_op, method_op
 
 # Weakref operations
 
@@ -16,7 +16,15 @@
 new_ref__with_callback_op = function_op(
     name="weakref.ReferenceType",
     arg_types=[object_rprimitive, object_rprimitive],
-    return_type=object_rprimitive,
+    return_type=weakref_rprimitive,
     c_function_name="PyWeakref_NewRef",
     error_kind=ERR_MAGIC,
 )
+
+deref_op = method_op(
+    name="__call__",
+    arg_types=[weakref_rprimitive],
+    return_type=object_rprimitive,
+    c_function_name="PyWeakref_GetRef",
+    error_kind=ERR_NEG_INT,
+)
diff --git a/mypyc/test-data/irbuild-weakref.test b/mypyc/test-data/irbuild-weakref.test
@@ -15,14 +15,17 @@ L0:
 import weakref
 from typing import Any, Callable
 def f(x: object, cb: Callable[[object], Any]) -> object:
-    return weakref.ref(x, cb)
+    return weakref.ref(x, cb)()
 
 [out]
 def f(x, cb):
-    x, cb, r0 :: object
+    x, cb :: object
+    r0 :: weakref.ReferenceType
+    r1 :: object
 L0:
     r0 = PyWeakref_NewRef(x, cb)
-    return r0
+    r1 = PyWeakref_GetRef(r0)
+    return r1
 
 [case testFromWeakrefRef]
 from typing import Any, Callable
@@ -41,11 +44,14 @@ L0:
 from typing import Any, Callable
 from weakref import ref
 def f(x: object, cb: Callable[[object], Any]) -> object:
-    return ref(x, cb)
+    return ref(x, cb)()
 
 [out]
 def f(x, cb):
-    x, cb, r0 :: object
+    x, cb :: object
+    r0 :: weakref.ReferenceType
+    r1 :: object
 L0:
     r0 = PyWeakref_NewRef(x, cb)
-    return r0
+    r1 = PyWeakref_GetRef(r0)
+    return r1
