Skip to content

Fix disappearing errors when re-running dmypy check #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 9, 2023
Merged

Fix disappearing errors when re-running dmypy check #14835

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4569fa
Add test to demonstrate issue #9655
meshy Mar 4, 2023
1831cbd
Prove ignores without error codes also disappear
meshy Mar 12, 2023
6094fc4
Prove possibly-undefined errors disappear
meshy Mar 12, 2023
eac851b
Ensure errors persist after dmypy update
meshy Mar 13, 2023
5bfb6b5
Improve test names
meshy Mar 31, 2023
3d8d2b7
Add new failing tests
meshy Mar 31, 2023
520f8e8
Ensure errors persist after file change
meshy Apr 8, 2023
6c14e7d
Fix no-op file modification on Windows
meshy Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prove possibly-undefined errors disappear 
This test fails with the error:

    AssertionError: Command 3 (dmypy check -- bar.py) did not give expected output
    --- Captured stderr call ---
    Expected:
      bar.py:4: error: Name "a" may be undefined  [possibly-undefined] (diff)
      == Return code: 1                             (diff)
    Actual:
      (empty)

This test illustrates that possibly-undefined errors currently disappear
in the same way that 'Unused "type: ignore"' errors do as described in #9655.

Ref: #9655
  • Loading branch information
@meshy
meshy committed Mar 12, 2023
commit 6094fc46d12904eaec42c3e622645551b549e7e5
19 changes: 19 additions & 0 deletions test-data/unit/daemon.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,3 +556,22 @@ bar.py:2: error: "type: ignore" comment without error code [ignore-without-code
[file bar.py]
from foo.empty import *
a = 1 # type: ignore

[case testPossiblyUndefinedVarsPreservedAfterUpdate]
-- Regression test for https://github.com/python/mypy/issues/9655
$ dmypy start -- --enable-error-code possibly-undefined --no-error-summary
Daemon started
$ dmypy check -- bar.py
bar.py:4: error: Name "a" may be undefined [possibly-undefined]
== Return code: 1
$ dmypy check -- bar.py
bar.py:4: error: Name "a" may be undefined [possibly-undefined]
== Return code: 1

[file foo/__init__.py]
[file foo/empty.py]
[file bar.py]
from foo.empty import *
if False:
a = 1
a
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy