Skip to content

Type ignore comments erroneously marked as unused by dmypy #15043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unrequired changes to reprocess_nodes
The problem this solved has been addressed in another way, so we don't
need to do this re-analysis any more in order to fix the bug we've been
chasing.

This change is a partial revert of "Fix disappearing errors when
re-running dmypy check" from a few commits back.
  • Loading branch information
meshy committed Jan 11, 2024
commit 64cbe6b360f45af33e15b418cb739c60db6aa3ae
4 changes: 0 additions & 4 deletions mypy/server/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -1030,10 +1030,6 @@ def key(node: FineGrainedDeferredNode) -> int:
if graph[module_id].type_checker().check_second_pass():
more = True

graph[module_id].detect_possibly_undefined_vars()
graph[module_id].generate_unused_ignore_notes()
graph[module_id].generate_ignore_without_code_notes()

if manager.options.export_types:
manager.all_types.update(graph[module_id].type_map())

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy