Retain None as constraints bottom if no bottoms were provided
#19485
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: jax (https://github.com/google/jax)
- jax/experimental/pallas/ops/gpu/attention_mgpu.py:598: error: Unused "type: ignore" comment [unused-ignore]
+ jax/experimental/pallas/ops/gpu/attention_mgpu.py:597: error: Unused "type: ignore" comment [unused-ignore]
- jax/experimental/pallas/ops/gpu/attention_mgpu.py:619: error: Unused "type: ignore" comment [unused-ignore]
+ jax/experimental/pallas/ops/gpu/attention_mgpu.py:618: error: Unused "type: ignore" comment [unused-ignore]
|
|
Looks good, it only shifts the errors to inner contexts. |
ilevkivskyi
approved these changes
Jul 21, 2025
|
I even noticed that but then forgot again while looking at the changed test... It probably is:) |
|
Thank you for fixing!! |
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version replaces
None(which indicates "no items") with an empty union (=Uninhabited). This breaks inference in some cases.Fixes #19483.