Skip to content

Allow instantiation of Type[A], if A is abstract #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2017
Merged

Allow instantiation of Type[A], if A is abstract #2853

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0ff0cc
Some ideas
ilevkivskyi Nov 16, 2016
71ea62f
Work on corner cases, more tests
ilevkivskyi Feb 12, 2017
ec22e4d
Fix minor issues and lint
ilevkivskyi Feb 12, 2017
80c82e7
Formatting
ilevkivskyi Feb 12, 2017
f52a3bd
Merge branch 'master' into abstract-type-ok
ilevkivskyi Mar 9, 2017
65eab95
Apply review comments
ilevkivskyi Mar 21, 2017
4d2e6fd
Add test fixture; fix formatting
ilevkivskyi Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into abstract-type-ok
  • Loading branch information
@ilevkivskyi
ilevkivskyi authored Mar 9, 2017
commit f52a3bdb804c46d49c4ad5127fa583ee057ac4be
20 changes: 17 additions & 3 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,23 @@ def is_implicit_any(t: Type) -> bool:
ref_type = mypy.types.TypeType(ref_type)
erased = erase_to_bound(arg_type)
if not is_subtype_ignoring_tvars(ref_type, erased):
self.fail("The erased type of self '{}' "
"is not a supertype of its class '{}'"
.format(erased, ref_type), defn)
note = None
if typ.arg_names[i] in ['self', 'cls']:
if (self.options.python_version[0] < 3
and is_same_type(erased, arg_type) and not isclass):
msg = ("Invalid type for self, or extra argument type "
"in function annotation")
note = '(Hint: typically annotations omit the type for self)'
else:
msg = ("The erased type of self '{}' "
"is not a supertype of its class '{}'"
).format(erased, ref_type)
else:
msg = ("Self argument missing for a non-static method "
"(or an invalid type for self)")
self.fail(msg, defn)
if note:
self.note(note, defn)
if defn.is_class and isinstance(arg_type, CallableType):
arg_type.is_classmethod_class = True
elif isinstance(arg_type, TypeVarType):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy