Sort mypyc_targets in setup.py #6569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mypy_mypyc-wheels Travis build is currently broken on linux because of a mypyc bug that is dependent on the order of files passed to mypyc. I am fixing the bug (mypyc/mypyc#539), but this was complicated by files coming out of the file system APIs in an unspecified order. Sort the targets passed to mypyc so that the mypyc compilation process is deterministic.
gvanrossum
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypy_mypyc-wheels Travis build is currently broken on linux
because of a mypyc bug that is dependent on the order of files passed
to mypyc. I am fixing the bug
(mypyc/mypyc#539), but this was complicated by
files coming out of the file system APIs in an unspecified order.
Sort the targets passed to mypyc so that the mypyc compilation process
is deterministic.
(This I believe will happen to fix the mypy_mypyc-wheels build, because "suggestions" comes after "plugin" in the alphabet, but it isn't really fixed. I'll also be moving the mypyc pin.)