Analyze and check default arguments to lambdas #7306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to report errors in them and also is needed to support them in mypyc.
msullivan
added a commit
to mypyc/mypyc
that referenced
this pull request
Aug 8, 2019
Compute the defaults at function creation time and store them in globals (for toplevel functions) or in the function object (for nested functions). Fixes #336. No tests for lambdas yet because they are broken due to a mypy bug I've sent a fix up for (python/mypy#7306). (Also fix a silly lambda bug where defaults weren't supported I came across while testing.)
msullivan
added a commit
to mypyc/mypyc
that referenced
this pull request
Aug 8, 2019
Compute the defaults at function creation time and store them in globals (for toplevel functions) or in the function object (for nested functions). Fixes #336. No tests for lambdas yet because they are broken due to a mypy bug I've sent a fix up for (python/mypy#7306). (Also fix a silly lambda bug where defaults weren't supported I came across while testing.)
ilevkivskyi
approved these changes
Aug 9, 2019
| # Analyze default arguments | ||
| for arg in defn.arguments: | ||
| if arg.initializer: | ||
| arg.initializer.accept(self) |
There was a problem hiding this comment.
I assume you move this here because this method is already called on lambdas. I however see two problems with this:
- The comment on line 560 above becomes outdated (can't comment so far above).
- This can potentially cause problem with scopes if make some refactorings in future, so I would add a test like this (if we don't have one already):
def f(x=i): # Should give a 'Name not defined' error
i = 42
msullivan
added a commit
that referenced
this pull request
Aug 20, 2019
Compute the defaults at function creation time and store them in globals (for toplevel functions) or in the function object (for nested functions). Fixes mypyc/mypyc#336. No tests for lambdas yet because they are broken due to a mypy bug I've sent a fix up for (#7306). (Also fix a silly lambda bug where defaults weren't supported I came across while testing.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to report errors in them and also is needed to
support them in mypyc.