Respond to code review; partially disable heuristics when strict-opti…

…onal is disabled
python · Michael0x2a · Aug 25, 2019 · Jul 29, 2019 · Aug 16, 2019 · Aug 25, 2019
commit b75f886789552a3d4983390e8c9aec21c36912fa
diff --git a/mypy/checker.py b/mypy/checker.py
@@ -3312,14 +3312,30 @@ def visit_with_stmt(self, s: WithStmt) -> None:
                 exit_ret_type = self.check_async_with_item(expr, target, s.unanalyzed_type is None)
             else:
                 exit_ret_type = self.check_with_item(expr, target, s.unanalyzed_type is None)
+
+            # Based on the return type, determine if this context manager 'swallows'
+            # exceptions or not. We determine this using a heuristic based on the
+            # return type of the __exit__ method -- see the discussion in
+            # https://github.com/python/mypy/issues/7214 and the section about context managers
+            # in https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#conventions
+            # for more details.
+
+            exit_ret_type = get_proper_type(exit_ret_type)
             if is_literal_type(exit_ret_type, "builtins.bool", False):
                 continue
-            if is_literal_type(exit_ret_type, "builtins.bool", True):
-                exceptions_maybe_suppressed = True
-            elif (isinstance(exit_ret_type, Instance)
-                    and exit_ret_type.type.fullname() == 'builtins.bool'):
+
+            if (is_literal_type(exit_ret_type, "builtins.bool", True)
+                    or (isinstance(exit_ret_type, Instance)
+                        and exit_ret_type.type.fullname() == 'builtins.bool'
+                        and state.strict_optional)):
+                # Note: if strict-optional is disabled, this bool instance
+                # could actually be an Optional[bool].
                 exceptions_maybe_suppressed = True
+
         if exceptions_maybe_suppressed:
+            # Treat this 'with' block in the same way we'd treat a 'try: BODY; except: pass'
+            # block. This means control flow can continue after the 'with' even if the 'with'
+            # block immediately returns.
             with self.binder.frame_context(can_skip=True, try_frame=True):
                 self.accept(s.body)
         else:

diff --git a/mypy/types.py b/mypy/types.py
@@ -2405,10 +2405,8 @@ def remove_optional(typ: Type) -> ProperType:
         return typ
 
 
-def is_literal_type(typ: Type, fallback_fullname: str, value: LiteralValue) -> bool:
-    """Returns 'true' if this type is a LiteralType with the given value
-    and underlying base fallback type.
-    """
+def is_literal_type(typ: ProperType, fallback_fullname: str, value: LiteralValue) -> bool:
+    """Check if this type is a LiteralType with the given fallback type and value."""
     if isinstance(typ, Instance) and typ.last_known_value:
         typ = typ.last_known_value
     if not isinstance(typ, LiteralType):