python · msullivan · Aug 29, 2019 · Aug 28, 2019 · Aug 29, 2019
diff --git a/mypy/fixup.py b/mypy/fixup.py
@@ -76,6 +76,7 @@ def visit_symbol_table(self, symtab: SymbolTable) -> None:
                     stnode = lookup_qualified_stnode(self.modules, cross_ref,
                                                      self.allow_missing)
                     if stnode is not None:
+                        assert stnode.node is not None
                         value.node = stnode.node
                     elif not self.allow_missing:
                         assert stnode is not None, "Could not find cross-ref %s" % (cross_ref,)

diff --git a/mypy/nodes.py b/mypy/nodes.py
@@ -2986,8 +2986,10 @@ def serialize(self, prefix: str, name: str) -> JsonDict:
             assert self.node is not None, '%s:%s' % (prefix, name)
             if prefix is not None:
                 fullname = self.node.fullname()
-                if (fullname is not None and '.' in fullname and
-                        fullname != prefix + '.' + name
+                if (fullname is not None and '.' in fullname
+                        and fullname != prefix + '.' + name
+                        # If it only doesn't match because of -redefinition, that is OK
+                        and fullname != prefix + '.' + name.split('-redefinition')[0]
                         and not (isinstance(self.node, Var)
                                  and self.node.from_module_getattr)):
                     data['cross_ref'] = fullname

diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -3114,6 +3114,7 @@ def process_module_assignment(self, lvals: List[Lvalue], rval: Expression,
                         # never create module alias except on initial var definition
                         elif lval.is_inferred_def:
                             lnode.kind = self.current_symbol_kind()
+                            assert rnode.node is not None
                             lnode.node = rnode.node
 
     def process__all__(self, s: AssignmentStmt) -> None:

diff --git a/test-data/unit/fine-grained.test b/test-data/unit/fine-grained.test
@@ -9160,3 +9160,27 @@ Data = Tuple[User, File]
 [typing fixtures/typing-full.pyi]
 [out]
 ==
+
+[case testClassRedef]
+# An issue involved serializing these caused crashes in the past
+
+[file a.py]
+class A:
+    pass
+
+x = 0
+
+[file a.py.2]
+class A:
+    a = A()
+
+x = '0'
+
+[file b.py]
+from a import A, x
+
+class A: # type: ignore
+    pass
+
+[out]
+==