Skip to content

Check syntax errors in "# type: ignore[code]" comments #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 27, 2019
Merged

Check syntax errors in "# type: ignore[code]" comments #7460

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
53748ea
Catch various errors in error codes
JukkaL Sep 3, 2019
0637acf
Fix Python 2
JukkaL Sep 3, 2019
83b8626
Fixes
JukkaL Sep 3, 2019
9967f96
Fix self check
JukkaL Sep 3, 2019
4c7c8bb
Minor refactoring
JukkaL Sep 4, 2019
e183ae5
Add test cases and simplify a bit
JukkaL Sep 4, 2019
f5e91d7
Minor refactoring
JukkaL Sep 4, 2019
95bdb29
Fix and clean up
JukkaL Sep 4, 2019
4dee365
Add comment
JukkaL Sep 4, 2019
dd11790
Add docstring
JukkaL Sep 4, 2019
0eee9b4
Merge branch 'master' into errcode-check-syntax
JukkaL Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor refactoring
  • Loading branch information
@JukkaL
JukkaL committed Sep 4, 2019
commit f5e91d724605dc069f66bf3e1121e9b62b8a9995
9 changes: 3 additions & 6 deletions mypy/fastparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,12 @@ def parse(source: Union[str, bytes],


def parse_type_ignore_tag(tag: Optional[str]) -> Optional[List[str]]:
if not tag:
if not tag or tag.strip() == '':
return []
m = re.match(r'\s*\[([^]#]*)\]\s*(#.*)?$', tag)
if m is None:
if tag.strip() == '':
return []
else:
# Invalid "# type: ignore" comment.
return None
# Invalid "# type: ignore" comment.
return None
return [code.strip() for code in m.group(1).split(',')]


Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy