Skip to content

Point incompatible assignment errors to rvalue instead of lvalue #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2019
Merged

Point incompatible assignment errors to rvalue instead of lvalue #7569

merged 3 commits into from
Sep 27, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Sep 27, 2019

This seems more logical. If there is a tuple lvalue, we point to the
incompatible tuple item.

Note that this may break some # type: ignore statements since
the reported line number may change (but it usually doesn't).

@JukkaL
Point incompatible assignment errors to rvalue instead of lvalue
bb23709 
This seems more logical. If there is a tuple lvalue, we point to the
incompatible tuple item.
@JukkaL
Fix special case
568ce10
@JukkaL
Update failing tests
8e57aa8
ilevkivskyi
ilevkivskyi approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense! Do we need a similar change to augmented assignments like x += y? (Maybe self.msg.incompatible_operator_assignment(s.op, s) call in visit_operator_assignment_stmt` needs to be updated.)

@JukkaL
Copy link
Collaborator Author

JukkaL commented Sep 27, 2019

Do we need a similar change to augmented assignments

They work like this already.

@JukkaL JukkaL merged commit e88ff4c into master Sep 27, 2019
@JukkaL JukkaL mentioned this pull request Sep 27, 2019
Closed
@JelleZijlstra JelleZijlstra deleted the columns-4-assign branch September 30, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukkaL @ilevkivskyi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy