Fix spurious errors in inherited dataclasses in incremental mode #7596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dataclasses plugin incorrectly expected json to preserve the ordering of its dictionaries, which led to spurious errors about "Attributes without a default cannot follow attributes with one". Worse, the errors are reported in the wrong file: they use the line number of the attribute but the file of the dataclass being checked! Fix the spurious error by serializing attributes in a list, since we care about the order. Reporting this error for attributes in parent classes is actually useful, since multiple inheritance can cause this error. Report the error at the class definition site causing the problem instead. (The error message here could certainly be improved, but right now I just want to fix the "wrong file" bugs, which are I think the worst kind of bugs after crashes.)
ilevkivskyi
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataclasses plugin incorrectly expected json to preserve
the ordering of its dictionaries, which led to spurious errors
about "Attributes without a default cannot follow attributes with one".
Worse, the errors are reported in the wrong file: they use the line
number of the attribute but the file of the dataclass being checked!
Fix the spurious error by serializing attributes in a list, since we
care about the order.
Reporting this error for attributes in parent classes is actually
useful, since multiple inheritance can cause this error. Report the
error at the class definition site causing the problem instead.
(The error message here could certainly be improved, but right
now I just want to fix the "wrong file" bugs, which are I think
the worst kind of bugs after crashes.)