[mypyc] Reorganization of headers and declarations #7634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the headers we generate into internal headers (containing type declarations) and external headers (containing function and object declarations) and refactors declarations to be much more driven by HeaderDeclaration objects. This will allow us to use HeaderDeclaration information to populate structures for dynamic linking in separate compilation.
JukkaL
approved these changes
Oct 7, 2019
mypyc/emit.py
Outdated
| decl: C source code for the declaration. | ||
| defn: Optionally, C source code for a definition. | ||
| dependencies: The names of any objects that must be declared prior. | ||
| is_type: Whether the declaration is of a type. |
There was a problem hiding this comment.
Be more explicit about what we mean by 'type' here, since it's a fuzzy concept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the headers we generate into internal headers (containing
type declarations) and external headers (containing function and
object declarations) and refactors declarations to be much more driven
by HeaderDeclaration objects. This will allow us to use
HeaderDeclaration information to populate structures for dynamic
linking in separate compilation.