Skip to content

Produce error when NamedTuple is assigned to attribute #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Produce error when NamedTuple is assigned to attribute #7662

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c062be
Produce error when NamedTuple is assigned to attribute
AFanaei Oct 9, 2019
91a477d
An idea to fix CI
AFanaei Oct 10, 2019
6651401
Use isinstance with a tuple
AFanaei Oct 12, 2019
4129bf9
Move tests to pythoneval
AFanaei Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
An idea to fix CI
  • Loading branch information
@AFanaei
AFanaei committed Oct 10, 2019
commit 91a477d7ddd9e8ce10558bcf211213c695eb0093
3 changes: 2 additions & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,7 +2120,8 @@ def analyze_namedtuple_assign(self, s: AssignmentStmt) -> bool:
"""Check if s defines a namedtuple."""
if isinstance(s.rvalue, CallExpr) and isinstance(s.rvalue.analyzed, NamedTupleExpr):
return True # This is a valid and analyzed named tuple definition, nothing to do here.
if len(s.lvalues) != 1 or type(s.lvalues[0]) not in [NameExpr, MemberExpr]:
if len(s.lvalues) != 1 or not (isinstance(s.lvalues[0], NameExpr) or
isinstance(s.lvalues[0], MemberExpr)):
return False
lvalue = s.lvalues[0]
name = lvalue.name
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy