Invoke get_dynamic_class_hook on method calls #7704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Oct 15, 2019
| # check if method call | ||
| if isinstance(call.callee, MemberExpr): | ||
| callee_expr = call.callee.expr | ||
| if isinstance(callee_expr, NameExpr) and callee_expr.fullname: |
There was a problem hiding this comment.
Suggested change
| if isinstance(callee_expr, NameExpr) and callee_expr.fullname: | |
| if isinstance(callee_expr, RefExpr) and callee_expr.fullname: |
| fname = callee_expr.fullname + '.' + method_name | ||
| # else check if function call | ||
| elif isinstance(call.callee, RefExpr): | ||
| fname = call.callee.fullname |
There was a problem hiding this comment.
I believe the order is wrong here: a RefExpr (including MemberExpr) with a non-None full name should always take precedence.
| MyManager = Manager.from_queryset(QuerySet) | ||
|
|
||
| reveal_type(MyManager()) # N: Revealed type is '__main__.MyManager' | ||
| reveal_type(MyManager().attr) # N: Revealed type is 'builtins.str' |
There was a problem hiding this comment.
Please add a check here that MyManager can be used as an annotation for a function argument.
msullivan
requested changes
Oct 22, 2019
|
@mkurnikov Note a competing PR appeared #7990, will you have time to update your PR soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7266