Skip to content

Fix issubclass() to narrow down types of type variables #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2019
Merged

Fix issubclass() to narrow down types of type variables #7930

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
796f527
add testcase
TH3CHARLie Nov 12, 2019
238bfa8
modify find_isinstance_check in checker.py to fix bug
TH3CHARLie Nov 12, 2019
5b35e9d
adjust branch statement in checker.py, modify testcase
TH3CHARLie Nov 13, 2019
df62cbc
refactor issubclass check into helper function
TH3CHARLie Nov 13, 2019
316cca7
modify test by adding new class with different upper bound, add docst…
TH3CHARLie Nov 13, 2019
e987e42
modify testcase, modify helper function name
TH3CHARLie Nov 13, 2019
8ab0d96
Remove redundant parens
ilevkivskyi Nov 14, 2019
fe59c0d
Merge branch 'master' into fix-issubclass
ilevkivskyi Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant parens
  • Loading branch information
@ilevkivskyi
ilevkivskyi authored Nov 14, 2019
commit 8ab0d96b8d2d53557c65e1b60d76a8396c9dd5e7
2 changes: 1 addition & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4178,7 +4178,7 @@ def infer_issubclass_maps(self, node: CallExpr,
"""Infer type restrictions for an expression in issubclass call."""
vartype = type_map[expr]
type = get_isinstance_type(node.args[1], type_map)
if (isinstance(vartype, TypeVarType)):
if isinstance(vartype, TypeVarType):
vartype = vartype.upper_bound
vartype = get_proper_type(vartype)
if isinstance(vartype, UnionType):
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy