Skip to content

Ignore invalid self types in constructors #7946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Ignore invalid self types in constructors #7946

merged 1 commit into from
Nov 13, 2019

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Nov 13, 2019 •
edited
Loading

This previously caused small troubles in Dropbox internal codebase C (because of weird annotations).

For example if an __init__() of class C had its self argument annotated with one of its superclasses B, this made all calls to C() inferred as B, causing spurious errors.

This PR also makes explicit types in __new__() and __init__() treated in a more similar way.

JukkaL
JukkaL approved these changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe also make the commit message explain the issue this fixes in more detail, and replace 'C' with "Dropbox internal codebase C" or something.

@ilevkivskyi
Copy link
Member Author

Maybe also make the commit message explain the issue this fixes in more detail, and replace 'C' with "Dropbox internal codebase C" or something.

👍

@ilevkivskyi ilevkivskyi merged commit f136e29 into python:master Nov 13, 2019
@ilevkivskyi ilevkivskyi deleted the tighten-init-overload branch November 13, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @JukkaL
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy