[mypyc] Fix some deserialization related issues #7989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Nov 21, 2019
mypyc/test/test_run.py
Outdated
| # Check that serialization works on this IR | ||
| check_serialization_roundtrip(ir) | ||
| # Check that serialization works on this IR. (Only on the first | ||
| # step because the test doesn't track the contexts and ir only |
There was a problem hiding this comment.
It's unclear to me what "track the contexts" means here.
Certain parts of the mypy AST aren't present and we were relying on them anyways. This caused a crash when subclassing and classes not making it into the type table, preventing using fast paths.
bad0228 to
7341d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain parts of the mypy AST aren't present and we were relying on
them anyways. This caused a crash when subclassing and classes not
making it into the type table, preventing using fast paths.