Meaningful message with long tuple initializer #7995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, Python3.8 tests continue to fail because their errors are reported one row different from previous version. |
JukkaL
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Thanks for the PR! I left a few commits about code style and formatting of the messages. You can perhaps avoid the Python 3.8 error by reformatting the code a bit so that all Python versions report the same line. Python 3.8 changed the locations of various AST nodes a bit.
|
@JukkaL Hi, if you have any time could you please review this as I think it’s nearly finished with some minor fixes maybe |
JukkaL
reviewed
Dec 2, 2019
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7977
Current format of error message(especially for item-by-item case) need discussion
request for review if you are free @JukkaL @ilevkivskyi