Skip to content

Enable a bunch of skipped tests #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 27, 2019
Merged

Enable a bunch of skipped tests #8024

merged 7 commits into from
Nov 27, 2019

Conversation

ilevkivskyi
Copy link
Member

This PR enables all skipped tests that can be enabled.

There are still 24 skipped tests left that still fail.

JukkaL
JukkaL approved these changes Nov 27, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that so many issues have been fixed (and we can enable more test coverage). Thanks!

@ilevkivskyi ilevkivskyi mentioned this pull request Nov 27, 2019
Merged
@ilevkivskyi ilevkivskyi merged commit 1013b63 into python:master Nov 27, 2019
@ilevkivskyi ilevkivskyi deleted the enable-skipped-tests branch November 27, 2019 20:09
ilevkivskyi added a commit that referenced this pull request Dec 3, 2019
@ilevkivskyi
Treat --python-version X.Y and --python-version=X.Y in tests equally (#…
914f0f9 
…8026)

While working on #8024 I noticed that `# flags: --python-version X.Y` and `# flags: --python-version=X.Y` are not treated equally by the test harness, namely the latter is actually ignored. This PR should fix this, because both forms are actually used in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @JukkaL
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy