Skip to content

Stubgen: normalize input paths when finding common parent directory for out files #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2020
Merged

Stubgen: normalize input paths when finding common parent directory for out files #8067

merged 9 commits into from
Oct 18, 2020

Conversation

hoefling
Copy link
Contributor

@hoefling hoefling commented Dec 3, 2019

Close #8065.

JukkaL
JukkaL reviewed Dec 4, 2019
View reviewed changes
@hoefling hoefling changed the title Stubgen: use pathlib for finding common parent directory for out files Stubgen: don't use unconditional loop for finding common parent directory for out files Dec 4, 2019
JukkaL
JukkaL reviewed Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I have a few more comments.

@hoefling hoefling changed the title Stubgen: don't use unconditional loop for finding common parent directory for out files Stubgen: normalize input paths when finding common parent directory for out files Dec 15, 2019
@hoefling
Copy link
Contributor Author

Done, sorry for the delay - caught the flu.

@hoefling
Copy link
Contributor Author

@JukkaL may I kindly ask about reviewing the latest changes?

@hoefling hoefling requested a review from JukkaL February 21, 2020 14:48
hoefling added 9 commits August 1, 2020 13:57
@hoefling
rewrote common_dir_prefix using pathlib
00da85f 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
use pathlib to normalize expected paths in common_dir_prefix test
86ab3ca 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
replaced pathlib usage with os.path, added windows-specific test for …
65c6d66 
…common_dir_prefix

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
add missing typings
16eab28 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
fix flake8 warnings
4b27f98 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
switch to unittest.skipIf instead of pytest marks
ebaff04 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
extend existing test for mixed separators in path
b043393 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
normalize paths + use os-specific separator
c8eb92b 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling
reduce diff
23f3646 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@hoefling hoefling force-pushed the stubgen-endless-loop-fix branch from a4a6627 to 23f3646 Compare August 1, 2020 11:58
hauntsaninja
hauntsaninja approved these changes Oct 18, 2020
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hope you've recovered from your flu :-)

@hauntsaninja hauntsaninja merged commit aed5642 into python:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stubgen stuck in an endless loop in 0.750
3 participants
@hoefling @JukkaL @hauntsaninja
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy