Skip to content

Support type inference for defaultdict() #8167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2019
Merged

Support type inference for defaultdict() #8167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7c2236
Support type inference for defaultdict()
JukkaL Dec 4, 2019
481190d
Update test case
JukkaL Dec 12, 2019
35e0eff
Fix test
JukkaL Dec 18, 2019
b823448
Update comments
JukkaL Dec 18, 2019
b28f6ce
Revert typeshed change
JukkaL Dec 18, 2019
21298b1
Respond to feedback
JukkaL Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@JukkaL
JukkaL committed Dec 18, 2019
commit 35e0eff7e9c01d4cd47f47c53b547b38cb97d7b1
2 changes: 1 addition & 1 deletion mypy/typeshed
Open in desktop
Submodule typeshed updated 5 files
+7 −9 stdlib/2/random.pyi
+25 −37 stdlib/2and3/csv.pyi
+205 −334 stdlib/2and3/socket.pyi
+21 −50 stdlib/3/tempfile.pyi
+3 −9 third_party/3/orjson.pyi
3 changes: 3 additions & 0 deletions mypyc/test-data/fixtures/ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ class ellipsis: pass
# Primitive types are special in generated code.

class int:
@overload
def __init__(self) -> None: pass
@overload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to mypyc needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case relies on the int() constructor since it uses defaultdict(int).

def __init__(self, x: object, base: int = 10) -> None: pass
def __add__(self, n: int) -> int: pass
def __sub__(self, n: int) -> int: pass
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy