Skip to content

stubtest: add tests #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 13, 2020
Merged

stubtest: add tests #8380

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6b6775c
stubtest: move into mypy
Feb 6, 2020
6010016
stubtest: add entry point to setup.py
Feb 6, 2020
1ec9503
stubtest: use mypy.utils.check_python_version
Feb 6, 2020
ac4ae2a
stubtest: split up main to make it easier to test
Feb 6, 2020
0e6bf85
stubtest: improvements to signature checking
Feb 6, 2020
0efa73d
stubtest: [minor] follow project style / track coverage better
Feb 7, 2020
a54dc9f
stubtest: [minor] output filename more consistently
Feb 7, 2020
3162788
stubtest: [minor] remove no longer necessary optional
Feb 7, 2020
ea3f83f
stubtest: fix module level variables missing at runtime
Feb 7, 2020
6d63451
stubtest: handle compile errors
Feb 7, 2020
3ed99bb
stubtest: [minor] remove black's colon spaces
Feb 7, 2020
ac5b12a
stubtest: [minor] remove black's commas
Feb 7, 2020
37fe91c
stubtest: [minor] handle a case in get_mypy_type_of_runtime_value
Feb 7, 2020
5e0949c
stubtest: add tests
Feb 7, 2020
b788ddb
stubtest: [minor] catch more warnings
Feb 7, 2020
882fb46
stubtest: add annotation to help mypyc out
Feb 7, 2020
1641fe4
stubtest: replace use of find for Windows compatibility
Feb 7, 2020
7e7fe25
teststubtest: NamedTemporaryFile doesn't work on Windows
Feb 7, 2020
7f6e0d5
stubtest: [minor] make str(signature) deterministic
Feb 7, 2020
436586f
mypyc: exclude stubtest.py
Feb 8, 2020
6d1f84f
stubtest: fix LiteralType misuse for mypyc
Feb 8, 2020
8fda109
stubtest: work around a bug in early versions of py35
Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mypyc: exclude stubtest.py
  • Loading branch information
hauntsaninja committed Feb 11, 2020
commit 436586f8ffb34016ddacd146f28e90ef1aea9d36
3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ def run(self):
# We don't populate __file__ properly at the top level or something?
# Also I think there would be problems with how we generate version.py.
'version.py',

# Written by someone who doesn't know how to deal with mypyc
'stubtest.py',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I never figured out how to get vars / dict to work. This is the big off switch I mentioned in #8380 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I inferred from some of the changes since that you'd figured out a workaround. I merged this change now and hopefully we'll eventually find a way to remove the special-casing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workarounds were for the bug in early Python 3.5s and a valid mypyc complaint from another module.
I’ll try Sully’s suggestion to see if we can remove stubtest from the blacklist.

)) + (
# Don't want to grab this accidentally
os.path.join('mypyc', 'lib-rt', 'setup.py'),
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy