[mypyc] Refactor: remove cyclic deps by extracting genops visitor #8430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple visitor module that doesn't contain any implementation and just
dispatches to various transform implementations. The main benefit is that
the implementations don't need to depend on the visitor (and thus also don't
need to depend on the other implementations) and that
IRBuilderdoesn'tneed to depend on the implementations.
Also extract the driver function to another module, as this would otherwise
cause an import cycle.
Some cyclic dependencies remain and wouldn't be hard to get rid of. I
wanted to keep this PR relatively simple so I didn't fix them yet.
Work on mypyc/mypyc#714.