Dynamically disallow instantiating traits/interpreted subclasses #9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a bunch of segfaults Closes #9001. Closes #8360. It doesn't close either of them in a satisfactory way, though. Really they would like actual support, which I've opened as mypyc/mypyc#754. Related to mypyc/mypyc#655. (At some point there used to be working dynamic checks for at least one of these cases. Not sure when that broke.)
This was referenced Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a bunch of segfaults
Closes #9001. Closes #8360. It doesn't close either of them in a
satisfactory way, though. Really they would like actual support, which
I've opened as mypyc/mypyc#754.
Related to mypyc/mypyc#655. (At some point there used to be working
dynamic checks for at least one of these cases. Not sure when that
broke.)