Skip to content

Fixes corner case for comparing nested overloads #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2020
+4 −0
Merged

Fixes corner case for comparing nested overloads #9259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf5d82
Fixes our very own case for comparing nested overloads
sobolevn Aug 4, 2020
218ee5d
Update subtypes.py
sobolevn Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update subtypes.py
  • Loading branch information
@sobolevn
sobolevn authored Aug 5, 2020
commit 218ee5df4c6d6df77dc4c745891b70e82bec3050
2 changes: 0 additions & 2 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,6 @@ def visit_overloaded(self, left: Overloaded) -> bool:
elif isinstance(right, Overloaded):
if left == self.right:
# When it is the same overload, then the types are equal.
# This was originally introduced as a fix / hack for:
# https://github.com/python/mypy/issues/9147
return True

# Ensure each overload in the right side (the supertype) is accounted for.
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy