[mypyc] New style new_tuple_op #9298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH3CHARLie
commented
Aug 13, 2020
| @@ -1840,7 +1840,8 @@ def h(): | |||
| r2, r3 :: object | |||
| r4, r5 :: dict | |||
| r6 :: str | |||
| r7, r8 :: object | |||
| r7 :: object | |||
| r8 :: object | |||
There was a problem hiding this comment.
I have located the source cause of this problem. I'll submit a separate PR for that since it's going to change the IR tests in a lot of places(originally when we introduce const_int_regs into pretty IR printing, we didn't find out this happening)
JukkaL
reviewed
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports new-style
new_tuple_op, which completes the support of all tuple ops.