PEP 791: address PEP review comments #4430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
963f154 to
86e15a2
Compare
* add submodule variant
86e15a2 to
8cdce7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
hugovk
reviewed
May 24, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
vstinner
reviewed
May 24, 2025
vstinner
reviewed
May 28, 2025
zooba
reviewed
May 28, 2025
177f73b to
ae03c4b
Compare
|
@vstinner, "Open Issues" section was removed. Please review. @serhiy-storchaka, I would appreciate your feedback as this is close to final version (for SC). Let me know if you feel that argumentation is not strong enough. I think it's better to mark this PEP as "Deferred" than reject the idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4430.org.readthedocs.build/pep-0791/