Skip to content

PyLong_GetSign will be added in 3.14a0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

PyLong_GetSign will be added in 3.14a0 #102

merged 1 commit into from
Jul 8, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 8, 2024

Follow on from #99.

PyLong_GetSign will be added in 3.14.0a0:

I was getting an error building with latest main:

      In file included from src/encode.c:28:
      src/thirdparty/pythoncapi_compat.h:1285:1: error: static declaration of 'PyLong_GetSign' follows non-static declaration
      PyLong_GetSign(PyObject *obj, int *sign) {
      ^
      /Users/hugo/github/python/cpython/main/Include/cpython/longobject.h:66:17: note: previous declaration is here
      PyAPI_FUNC(int) PyLong_GetSign(PyObject *v, int *sign);
                      ^
      1 error generated.

Fix the version check and comment.

@vstinner vstinner merged commit ea1f7f6 into python:main Jul 8, 2024
21 checks passed
@vstinner
Copy link
Member

vstinner commented Jul 8, 2024

Merged, thank you.

@hugovk hugovk deleted the fix-PyLong_GetSign-version branch July 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @vstinner @erlend-aasland
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy