Redirect legacy community page #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permanently redirect /community-landing/ to /community/ Resolves python#2294
eamanu
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
But IMO, this PR does not fix #2294 because python community merchandise is not found. https://www.python.org/community-landing/merchandise/
Use regular expression to redirect all legacy 'community-landing/' paths, including any children.
|
Thank you @eamanu , I made a commit to address that. I switched to regex to catch all of the old URLs. |
|
❤️
|
|
Just seeing this but doing the redirect in nginx is more efficient and where we retain most static/long-lived redirects: https://github.com/python/pythondotorg/blob/main/config/nginx.conf.erb |
ewdurbin
added a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permanently redirect legacy community page, /community-landing/, to /community/.
Resolves #2294