Hide releases from Downloads page when they have no files to download #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCoffee
approved these changes
May 26, 2025
|
I hope those before/after images are swapped, because it looks like it's added empty entries. Also, should this have deployed yet? I don't see any change on the live site, but maybe I shouldn't expect to - I really don't know. |
It has deployed, but everything under /downloads has a massive cache TTL: pythondotorg/config/nginx.conf Line 349 in 142583b You can purge a given URL with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is most obvious on the macOS page, which has a lot of releases listed with no files. For a downloads page, it looks a bit silly.
Most critically, this should hide the Python install manager releases from macOS and Source pages, as it will have no files. An alternative would be to hard-code its ID into the templates, but this way seemed better.
There might be a better way to check if there are no files, I'm not sure. And yes, this makes the
{% empty %}blocks redundant, but they're also harmless, and if this check is ever changed at least the page will still work.